RFR: 8265465: jcmd VM.cds should keep already dumped archive when exceptions happens [v5]

Calvin Cheung ccheung at openjdk.java.net
Fri May 7 00:12:09 UTC 2021


On Fri, 7 May 2021 00:02:56 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java line 78:
>> 
>>> 76:         print2ln(test_count++ + " Set target dir not writable, do dynamic dump");
>>> 77:         setKeepArchive(true);
>>> 78:         outputDirFile.setWritable(true);
>> 
>> Should the comment be `// Set target dir writable ...` ? (since you're setting the dir to writable at line 78)
>
> The comment is for the testing item --- that is consistent with println contents.
> The first set 'true' is for get the archive and keep the archive,  the real test is after set it to 'false', the test will fail and we check the previous archive still available.

I see.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3886


More information about the core-libs-dev mailing list