RFR: 8254598: StringDedupTable should use OopStorage [v2]

Kim Barrett kbarrett at openjdk.java.net
Fri May 7 08:28:47 UTC 2021


On Tue, 4 May 2021 11:47:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - more comment improvements
>>  - improve naming and comments around injected String flags
>>  - fix some typos in comments
>
> src/hotspot/share/classfile/javaClasses.hpp line 171:
> 
>> 169:   static inline bool is_latin1(oop java_string);
>> 170:   static inline bool no_deduplication(oop java_string);
>> 171:   static inline bool deduplication_requested(oop java_string);
> 
> Having a verb at the beginning like `is_deduplication_requested` sounds better.

"is_deduplication_requested" suggests there is currently a request, but this flag remains true even after the request is processed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3662


More information about the core-libs-dev mailing list