RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation

Alexey Semenyuk asemenyuk at openjdk.java.net
Fri May 7 17:32:21 UTC 2021


On Fri, 7 May 2021 02:48:44 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Replaced direct TKit.run() calls with Test annotation.
>  - Increased timeout for SigningPackageTest from default to 360 due to timeout. This is regression from JDK-8248904 due to changes done in signing and --remove-signature adds additional time since it is run per file.
>  - Fixed issue with jtreg.SkippedException which caused test to fail instead of being skipped, since it was wrapped in ExceptionBox.

I'd also make TKit.run() method package private as it is not called from outside of jdk.jpackage.test package any more.

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java line 161:

> 159:         }
> 160: 
> 161:         if (throwable.getClass().getName().equals("jtreg.SkippedException")) {

Would it make sense to have check: `if (throwable instanceof Runnable)`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3911


More information about the core-libs-dev mailing list