RFR: JDK-8266797: Fix for 8266610 breaks the build on macos

[Vyom Tewari]

On Mon, 10 May 2021 08:46:15 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> Hi Vyom,
>> 
>> That fixes the include file problem but as this was obviously not tested on non-Linux have you checked that the rest of the fix for 8266610 works okay on non-Linux?
>> 
>> Thanks,
>> David
>
>> Hi Vyom,
>> 
>> That fixes the include file problem but as this was obviously not tested on non-Linux have you checked that the rest of the fix for 8266610 works okay on non-Linux?
>> 
>> Thanks,
>> David
> 
> Hi David,
> 
> Original fix  was intended to  Linux specific. Current  Fix  will not impact other platforms. 
> 
> There is existing test (java/nio/channels/FileChannel/BlockDeviceSize.java) which test the new code but currently it is silently passing without running the test. This test requires root access.
> 
> Please see the bug( https://bugs.openjdk.java.net/browse/JDK-8150539) 
> 
> Thanks,
> Vyom

> @vyommani how are you going to test this?

I tested locally at my Linux environment. we have a test "java/nio/channels/FileChannel/BlockDeviceSize.java" but  it requires root privileged , i ran this as well as a root.  Please  have a look into this(https://bugs.openjdk.java.net/browse/JDK-8150539).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3943