RFR: JDK-8266797: Fix for 8266610 breaks the build on macos

David Holmes dholmes at openjdk.java.net
Mon May 10 13:34:50 UTC 2021


On Mon, 10 May 2021 08:46:15 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

> Original fix was intended to Linux specific. Current Fix will not impact other platforms.

Your original fix failed to be Linux specific, so given you never actually tested it on other platforms you don't know whether another part of the fix is also not actually Linux-specific.

At a minimum ensure you have GitHub actions enabled so that your fixes get some basic cross-platform testing before they are integrated. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3943


More information about the core-libs-dev mailing list