RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

Alexey Semenyuk asemenyuk at openjdk.java.net
Mon May 10 15:36:26 UTC 2021


On Fri, 7 May 2021 23:07:02 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java line 161:
>> 
>>> 159:         }
>>> 160: 
>>> 161:         if (throwable.getClass().getName().equals("jtreg.SkippedException")) {
>> 
>> Would it make sense to have check: `if (throwable instanceof Runnable)`?
>
> Not sure. I do not think it will work. SkippedException extends RuntimeException, so not sure why we need to check it with Runnable.

My point is that if the exception is Runnable, there is no need to wrap it in ExceptionBox instance.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3911


More information about the core-libs-dev mailing list