Would anyone please reopen JDK-4991002?

[Mitsuru Kariya]

Thank you for your quick reply and precise advice.

> Once you have signed your OCA and have generated your proposed patch,
> feel free to create your PR.

I already have signed the OCA, so I'll start with a PR for an open 
issue, JDK-8153490.

Thanks,

On 2021-05-12 02:59, Lance Andersen wrote:
> Hi Mitsuru,
> 
> Thank you for your interest in contributing to the OpenJDK project
> 
> If you are not an Author, you can file bugs via
> https://bugreport.java.com/bugreport/
> 
> To contribute fixes,  you will need to sign an Oracle Committer
> Agreement(OCA).  Please see https://openjdk.java.net/contribute/ for
> more info
> 
> Please enter a new issue which you can use to address your
> SerialBlob/Clob fixes.  You will also need to  add the tests to verify
> the fix to the relevant tests in open/test/jdk/javax/sql/testng/test
> 
>  RowSets, in particular the Serialxxx classes, are seldom used (if at
> all) as there are better alternatives for an API.
> 
> Once you have signed your OCA and have generated your proposed patch,
> feel free to create your PR.
> 
> Best
> Lance
> 
>> On May 11, 2021, at 9:11 AM, Mitsuru Kariya
>> <mitsuru.kariya at oss.nttdata.com> wrote:
>> 
>> Hi,
>> 
>> While reading the source for SerialBlob, I found that
>> SerialBlob.position() does not work correctly.
>> So, I searched JBS and found the description in JDK-4991002 point 1,
>> but it was closed by Cannot Reproduce.
>> 
>> It can be reproduced easily like below.
>> 
>> SerialBlob sb = new SerialBlob(new byte[]{1, 2, 3, 4, 5});
>> System.out.println(sb.position(new byte[]{1, 3, 5}, 1));
>> 
>> It should output "-1"(not found) but the current implementation
>> outputs "3"(found at position 3).
>> 
>> So, would anyone please reopen JDK-4991002 for me?
>> (I cannot reopen it because I don't have an Author role.)
>> 
>> Furthermore, SerialClob has same problem and JDK-4991036 describes
>> it.
>> So, may I fix it together?
>> Or do I need to separate the PR from JDK-4991002?
>> 
>> JDK-4991002:The class javax.sql.rowset.serial.SerialBlob is too
>> buggy
>> https://bugs.openjdk.java.net/browse/JDK-4991002
>> 
>> JDK-4991036:The class javax.sql.rowset.serial.SerialClob is too
>> buggy
>> https://bugs.openjdk.java.net/browse/JDK-4991036
>> 
>> Please let me know if there is a better place to do so.
>> 
>> Thanks
> 
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com