RFR: 8265605: Cannot call BootLoader::loadClassOrNull before initPhase2 [v2]

Mandy Chung mchung at openjdk.java.net
Wed May 12 22:24:12 UTC 2021


On Wed, 12 May 2021 20:59:51 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 60:
>> 
>>> 58:     // Sets the ServicesCatalog for the specified loader using archived objects.
>>> 59:     private static void setArchivedServicesCatalog(
>>> 60:             ArchivedClassLoaders archivedClassLoaders, ClassLoader loader)
>> 
>> Thanks for the update. The formatting on L60 is messed now, can't the ArchivedClassLoaders go on the previous line? I don't have any other comments, it's worked out well.
>
> How about the latest version (4cd981c)? I removed the `archivedClassLoaders` argument; this also makes the callers simpler.

Looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3992


More information about the core-libs-dev mailing list