RFR: 8266291: (jrtfs) Calling Files.exists may break the JRT filesystem

Alan Bateman alanb at openjdk.java.net
Fri May 14 11:23:43 UTC 2021


On Fri, 14 May 2021 05:39:10 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> Problematic paths that start with /modules/modules prefix are handled properly

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 475:

> 473:             }
> 474:             // Make sure that the thing that follows "/modules/" is a module name.
> 475:             // This will rule out paths that start as "/modules/modules/".

The code change looks fine. I guess I would probably change the comment to say that it make sure that there is something ending with "/" after "/modules/" (as the code that it comments doesn't actually change for a module name).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4022


More information about the core-libs-dev mailing list