RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

[Lin Zang]

On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Lin Zang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update copyright
>>  - reuse arguments constructor for non-argument one.
>
> Hi Lin,
> 
> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.******@***.***>> wrote:
> 
> 
> 
> Hi Lance，
> Thanks a lot for your review. I will update the PR ASAP.
> May I ask your help to also review the CSR？
> 
> I believe we need to flush out some of the issues I raised that were not test related as they will result in updates to the javadoc which will require an update to the CSR.
> 
> 
> 
> Thanks!
> 
> BRs,
> Lin
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub<https://github.com/openjdk/jdk/pull/3072#issuecomment-805549600>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQPFO5R4INTAUFZ3QS6WL3TFGDXHANCNFSM4ZMLU6SA>.
> 
> ***@***.***
> 
> 
> 
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> ***@***.******@***.***>

Dear Lance(@LanceAndersen),

I have updated the CSR at https://bugs.openjdk.java.net/browse/JDK-8263793, which considered changes both for GZIPOutputStream and GZIPInputStream. Would you like to help check whether it looks reasonable?

I also did some investigation recently, and it shows there are rare cases that the optional fields are used in gzip file, and gunzip ingores them when uncompressing. 

So I believe the meaning of the PR is just to add the ability of setting/getting gzip file header info that defined in gzip specification.  As the use case is rare at present, I am not sure whether it is acceptable to have this PR.  

Thanks,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/3072