RFR: 8224243: Make AccessibleObject a sealed class [v2]

[Remko Popma]

On Fri, 21 May 2021 02:42:50 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Conceptually, AccessbileObject is a sealed class with a protected constructor stating
>> 
>>     Constructor: only used by the Java Virtual Machine.
>> 
>> With the language now supporting sealed classes, the AccessbileObject should be marked as sealed.
>> 
>> Executable and Field are the subclasses of AccessbileObject in the JDK; as Executable has subclasses, it is marked as non-sealed.
>> 
>> Please also review the corresponding CSR:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8224243
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update in response to review feedback.

Hi all, I am the author of picocli. 

I will look into moving away from extending `AccessibleObject` in picocli, but Éamonn McManus's comment about Guava equally applies to picocli: even with such a change, older versions of the library would fail on JDK 17.

So, thank you for reconsidering sealing `AccessibleObject` and choosing to seal `Executable` instead. That is a relief. :-)
 
(And many thanks to @kaspernielsen for making me aware of this issue!)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4133