RFR: 8267612: Declare package-private VarHandle.AccessMode/-Type counts

Mandy Chung mchung at openjdk.java.net
Mon May 24 16:34:09 UTC 2021


On Mon, 24 May 2021 11:26:51 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> Slightly reduce VarHandle startup overhead by introducing package-private COUNT constants for two enums

src/java.base/share/classes/java/lang/invoke/VarHandle.java line 1639:

> 1637:         GET_AND_UPDATE(Object.class);
> 1638: 
> 1639:         static final int COUNT = 5;

Suggestion:

        static final int COUNT = GET_AND_UPDATE.ordinal() + 1;


This would avoid the hardcoded count which is a bit fragile.

src/java.base/share/classes/java/lang/invoke/VarHandle.java line 1897:

> 1895:         ;
> 1896: 
> 1897:         static final int COUNT = 31;

Suggestion:

        static final int COUNT = GET_AND_BITWISE_XOR_ACQUIRE.ordinal() + 1;

-------------

PR: https://git.openjdk.java.net/jdk/pull/4164


More information about the core-libs-dev mailing list