RFR: 8224243: Make AccessibleObject a sealed class [v3]
Alan Bateman
alanb at openjdk.java.net
Tue May 25 07:08:12 UTC 2021
On Mon, 24 May 2021 21:54:09 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Conceptually, AccessbileObject is a sealed class with a protected constructor stating
>>
>> Constructor: only used by the Java Virtual Machine.
>>
>> With the language now supporting sealed classes, the AccessbileObject should be marked as sealed.
>>
>> Executable and Field are the subclasses of AccessbileObject in the JDK; as Executable has subclasses, it is marked as non-sealed.
>>
>> Please also review the corresponding CSR:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8224243
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Minor fixes.
> - Change to UnsupportedOperationException.
> - Merge branch 'master' into 8224243
> - Update in response to review feedback.
> - 8224243: Make AccessibleObject a sealed class
The updated proposal looks good although the JBS issue should probably be renamed as the proposal is no longer to seal AccessibleObject.
-------------
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4133
More information about the core-libs-dev
mailing list