RFR: 8267452: Delegate forEachRemaining in Spliterators.iterator() [v2]

Tagir F.Valeev tvaleev at openjdk.java.net
Wed May 26 01:20:51 UTC 2021


On Tue, 25 May 2021 15:49:55 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Tagir F. Valeev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test: formatting; tests for empty spliterator
>
> Oops i missed the bit about testing in the description. That's subtle, the `hasNext` occurs in the assert before the `forEachRemaining`. Could you add a comment that this is the primary purpose of the test since `SpliteratorTraversingAndSplittingTest` cannot do that for a spliterator wrapping an iterator?

@PaulSandoz added a comment, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4124


More information about the core-libs-dev mailing list