RFR: JDK-8276572: Fake libsyslookup.so library causes tooling issues

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Nov 4 12:43:09 UTC 2021


On Thu, 4 Nov 2021 04:19:02 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> The lack of anything to compile in `syslookup.c` is leading to a number of issues in our tooling, on some architectures more than others (s390x seems to be the most problematic).  They expect to be able to retrieve debuginfo and compiler flags from generated .so files and fail with libsyslookup.so
> 
> This simple patch adds a dummy function to `syslookup.c` so it appears more like a regular file to be compiled. I can't see this causing a problem with the symbol lookup, but we could filter it out on the Java side if need be.

Looks ok. As long as we don't introduce more dependencies.

One question: would introducing a static function (so, not visible in the resulting DLL) be good enough?

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6245


More information about the core-libs-dev mailing list