Integrated: JDK-8274686 : java.util.UUID#hashCode() should use Long.hashCode()
PROgrm_JARvis
duke at openjdk.java.net
Mon Nov 8 13:26:44 UTC 2021
On Mon, 4 Oct 2021 21:13:02 GMT, PROgrm_JARvis <duke at openjdk.java.net> wrote:
> This is trivial fix of [JDK-8274686](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8274686) which replaces manually-computed `int`-based `long` hash-code.
>
> Because `Long#hashCode(long)` uses other hashing function than the one currently used here:
>
> https://github.com/openjdk/jdk/blob/75d6688df9845ecb8f370b4cd2d5a36f13d3cdc0/src/java.base/share/classes/java/lang/Long.java#L1440-L1442
>
> the value of `hashCode()` will produce different result, however this does not seem to be a breaking change as `UUID#hashCode()` is not specified.
>
> ---
>
> Note: the comment to the bug states:
>
>> Moved to JDK for further discussions of the proposed enhancement.
>
> But as there seemed to be no corresponding discussion in core-libs-dev and the change looks trivial, I considered that it is appropriate to open a PR which (if needed) may be used for discussion (especially, considering the fact that its comments get mirrored to the ML).
This pull request has now been integrated.
Changeset: cc2cac13
Author: Petr Portnov <gh at progrm-jarvis.ru>
Committer: Roger Riggs <rriggs at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/cc2cac130cc28730a30d2e1d76bcb6ec8bc0b580
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
8274686: java.util.UUID#hashCode() should use Long.hashCode()
Reviewed-by: rriggs
-------------
PR: https://git.openjdk.java.net/jdk/pull/5811
More information about the core-libs-dev
mailing list