RFR: 8277015: Use blessed modifier order in Panama code

[Maurizio Cimadamore]

Hi Magnus,
as we're in the process of integrating new API changes (see [1]) - would 
it be possible to postpone this? I'd like to minimize merge conflicts, 
if that makes sense.

Thanks
Maurizio

[1] - https://github.com/openjdk/jdk/pull/5907

On 11/11/2021 14:57, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by Project Panama. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound.
>
> In this case, while the script did into the "correct" thing, it turns out that the method signatures in `src/jdk.incubator.vector/share/classes/jdk/incubator/vector` has some room for improvement... The files contains method headers which look like this:
>
>
>          final @Override
>          @ForceInline
>          long longToElementBits(...
>
>          @ForceInline
>          static long toIntegralChecked(...
>
>          @ForceInline
>          @Override final
>          ByteVector dummyVector(...
>
>
> My personal opinion is that these should have been written like this:
>
>
>          @Override
>          @ForceInline
>          final long longToElementBits(...
>
>          @ForceInline
>          static long toIntegralChecked(...
>
>          @ForceInline
>          @Override
>          final ByteVector dummyVector(...
>
>
> or possibly
>
>
>
>          @Override @ForceInline
>          final long longToElementBits(...
>
>          @ForceInline
>          static long toIntegralChecked(...
>
>          @ForceInline @Override
>          final ByteVector dummyVector(...
>
>
> If you want me to make that change as well as part of the fix, let me know.
>
> Furthermore, I don't know how much the code in mainline differs from the code in the Panama branches. If the discrepancy is large, you might want to run `bash bin/blessed-modifier-order.sh src/jdk.incubator.vector` and  `bash bin/blessed-modifier-order.sh src/jdk.incubator.foreign` in those branches.
>
> -------------
>
> Commit messages:
>   - 8277015: Use blessed modifier order in Panama code
>
> Changes: https://git.openjdk.java.net/jdk/pull/6355/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6355&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8277015
>    Stats: 21 lines in 13 files changed: 0 ins; 0 del; 21 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/6355.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/6355/head:pull/6355
>
> PR: https://git.openjdk.java.net/jdk/pull/6355