RFR: 8193682: Infinite loop in ZipOutputStream.close() [v10]

Ravi Reddy rreddy at openjdk.java.net
Mon Nov 15 16:45:34 UTC 2021


> Hi all,
> 
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
> 
> Thanks,
> Ravi

Ravi Reddy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Merge branch 'openjdk:master' into JDK-8193682
 - 8193682: Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682 : Infinite loop in ZipOutputStream.close()
 - 8193682: Infinite loop in ZipOutputStream.close()

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5522/files
  - new: https://git.openjdk.java.net/jdk/pull/5522/files/c315ab21..c66535fc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=08-09

  Stats: 937207 lines in 2953 files changed: 489188 ins; 435324 del; 12695 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5522.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5522/head:pull/5522

PR: https://git.openjdk.java.net/jdk/pull/5522


More information about the core-libs-dev mailing list