RFR: 4511638: Double.toString(double) sometimes produces incorrect results [v5]

[GuySteele]

On Mon, 15 Nov 2021 19:31:09 GMT, Raffaello Giulietti <duke at openjdk.java.net> wrote:

>> Hello,
>> 
>> here's a PR for a patch submitted on March 2020 [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a thing.
>> 
>> The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.
>> 
>> 
>> Greetings
>> Raffaello
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   4511638: Double.toString(double) sometimes produces incorrect results
>   
>   Enhanced intervals in MathUtils.
>   Updated references to Schubfach v4.

DragonBox is a very impressive further achievement over Schubfach, but its extra complexity is not without risk at this time. Also, I have not yet seen an analysis of its additional space overhead (code and data), if any.

I concur that it is a good decision at this point to get plain Schubfach going and well-tested in Java. If all goes well, then DragonBox could be considered in the future.

Guy Steele


On Nov 17, 2021, at 9:20 AM, mlbridge[bot] ***@***.******@***.***>> wrote:



Mailing list message from Raffaello ***@***.***> on ***@***.***>:

Hi Suminda,

please read my reply to you from May
https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-May/077081.html

Greetings
Raffaello

On 2021-11-17 14:54, Suminda Sirinath Salpitikorala Dharmasena wrote:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/3402*issuecomment-971626422__;Iw!!ACWV5N9M2RV99hQ!am0x1_Iy6HoXH4-mh9O90Q6qvI-DzE2WPaqSGojmEbjiwO6Hzl4NgG_JzfLUVQ_Q$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAXU22XTDNNY7LNWW3SKSE3UMO22FANCNFSM42TWJIOA__;!!ACWV5N9M2RV99hQ!am0x1_Iy6HoXH4-mh9O90Q6qvI-DzE2WPaqSGojmEbjiwO6Hzl4NgG_JzeS4T6_V$>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!ACWV5N9M2RV99hQ!am0x1_Iy6HoXH4-mh9O90Q6qvI-DzE2WPaqSGojmEbjiwO6Hzl4NgG_Jzc0Hy-AJ$> or Android<https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!ACWV5N9M2RV99hQ!am0x1_Iy6HoXH4-mh9O90Q6qvI-DzE2WPaqSGojmEbjiwO6Hzl4NgG_JzZIzVFIU$>.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3402