RFR: 8193682: Infinite loop in ZipOutputStream.close() [v11]
Ravi Reddy
rreddy at openjdk.java.net
Wed Nov 17 20:21:14 UTC 2021
> Hi all,
>
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
Added better try/catch/finally block at GZIPOutputStream.finish() , ZipOutputStream.closeEntry() and DeflaterOutputStream.close()
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5522/files
- new: https://git.openjdk.java.net/jdk/pull/5522/files/c66535fc..12a8371f
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=10
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5522&range=09-10
Stats: 31 lines in 3 files changed: 9 ins; 12 del; 10 mod
Patch: https://git.openjdk.java.net/jdk/pull/5522.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5522/head:pull/5522
PR: https://git.openjdk.java.net/jdk/pull/5522
More information about the core-libs-dev
mailing list