RFR: 8193682: Infinite loop in ZipOutputStream.close() [v12]

Lance Andersen lancea at openjdk.java.net
Wed Nov 17 21:28:43 UTC 2021


On Wed, 17 Nov 2021 21:04:20 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change in description of test case

Hi Ravi,

The current revision looks good to me.

Best
Lance

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5522


More information about the core-libs-dev mailing list