RFR: 8276141: XPathFactory set/getProperty method [v9]

Roger Riggs rriggs at openjdk.java.net
Thu Nov 18 22:35:47 UTC 2021


On Wed, 10 Nov 2021 17:28:05 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add setProperty/getProperty methods to the XPath API so that properties can be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust wording

Looks good.

src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 390:

> 388:      * @throws UnsupportedOperationException if the implementation does not
> 389:      * support the method
> 390:      * @throws NullPointerException if the {@code name} is {@code null}.

Drop the "." at the end of the sentence (to be consistent with the other throws).

src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 415:

> 413:      * @throws UnsupportedOperationException if the implementation does not
> 414:      * support the method
> 415:      * @throws NullPointerException if the {@code name} is {@code null}.

Ditto.

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6215


More information about the core-libs-dev mailing list