Integrated: 8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased

Roger Riggs rriggs at openjdk.java.net
Tue Nov 23 15:06:17 UTC 2021


On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> The `jdk.internal.ValueBased` annotation was incorrectly applied to subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html) requires that supertypes have no instance fields; AbstractMap has instance fields keySet and values.
> 
> Remove the internal @ValueBased annotation for subclasses of AbstractMap including:
> AbstractImmutableMap, Map1, and MapN.

This pull request has now been integrated.

Changeset: 5e7e2da2
Author:    Roger Riggs <rriggs at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/5e7e2da227cd2b5e2d3d1e2f59fb74ddd1835abb
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8272042: java.util.ImmutableCollections$Map1 and MapN should not be @ValueBased

Reviewed-by: mchung, iris, naoto, smarks

-------------

PR: https://git.openjdk.java.net/jdk/pull/6480


More information about the core-libs-dev mailing list