RFR: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories [v2]
Mandy Chung
mchung at openjdk.java.net
Wed Nov 24 17:06:44 UTC 2021
On Wed, 24 Nov 2021 10:05:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> minor fix to avoid casting
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/DependencyFinder.java line 277:
>
>> 275: throw (Error)t;
>> 276: } else {
>> 277: throw new Error(e);
>
> A minor suggestion is that you could avoid the casts with:
>
> Throwable cause = ...
> if (cause instanceof RuntimeException e) {
> throw e;
> } else if (cause instanceof Error e) {
> throw e;
> } else {
Fixed. Thanks for reminding.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6530
More information about the core-libs-dev
mailing list