RFR: 8276657: XSLT compilter tries to define a class with empty name
Naoto Sato
naoto at openjdk.java.net
Tue Nov 30 19:32:07 UTC 2021
On Tue, 30 Nov 2021 18:53:26 GMT, Joe Wang <joehw at openjdk.org> wrote:
> The result of Util.baseName(systemId) can be empty, causing the compiler to set an empty classname. Add a check to make sure it will not set the empty classname.
>
> Alternatively, it may report an error, but that would be disruptive. As the transform can proceed without the provided classname (by using the default), adding a check is better than reporting an error.
>
> I've verified the patch with the proposed fix for JDK-8276241. Harold has also confirmed it fixes the tests in his builds.
Looks good. `isEmpty()` can be used in place for `.equals("")`.
-------------
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6620
More information about the core-libs-dev
mailing list