Integrated: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test

[Alex Kasko]

On Thu, 30 Sep 2021 18:32:17 GMT, Alex Kasko <akasko at openjdk.org> wrote:

> I was working on backporting JDK-8268457 and found minor problems with the test introduced there:
> 
> 1. `compareWith*` helper methods are used without `Assert.assertTrue()` wrapping, so they are effectively ignored
> 
> 2. `this.getClass().getResourceAsStream()` is used to load test input data, it actually returns null in test run, so transformation is done without input data
> 
> Note, that SurrogateTest.zip reproducer attached to JDK-8268457 is valid and fully functional, problems likely were introduced when it was adapted into test.
> 
> The change is to the test only, it wraps `compareWith*` helpers and loads data the same way as XSL is loaded. Additionally `compareStringWithGold` was changed to `compareLinesWithGold` to exclude possible line endings problems.
> 
> Testing: checked that the test fails when JDK-8268457 code fix is reverted, checked that is passes on master.

This pull request has now been integrated.

Changeset: 7eb0372e
Author:    Alex Kasko <akasko at openjdk.org>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7eb0372e55f23275b12470593adc97f1b79bc965
Stats:     10 lines in 1 file changed: 3 ins; 1 del; 6 mod

8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test

Reviewed-by: joehw, shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/5779