RFR: 8193682: Infinite loop in ZipOutputStream.close() [v2]
Ravi Reddy
rreddy at openjdk.java.net
Mon Oct 11 13:46:11 UTC 2021
On Mon, 11 Oct 2021 13:42:35 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>>
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
>
> 8193682 : Infinite loop in ZipOutputStream.close()
I have updated the review with the new fix.
Instead of throwing an exception in close() method , Now when we get an exception during write inside deflate() , we will close the stream and throw the exception.
Updated the test case in TestNG format.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5522
More information about the core-libs-dev
mailing list