RFR: 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

[Martin Buchholz]

On Sat, 9 Oct 2021 17:54:16 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE

JDK sources should not contain dead unused fields - thanks for fixing.

The change to use newLength in this file should have adjusted the javadoc of newCapacity, perhaps simply to refer to ArraysSupport.SOFT_MAX_ARRAY_LENGTH instead.

That sounds like a job for Jim Laskey as the author of
commit 03642a01af7123298d6524a98c99a3934d35c11b
Author: Jim Laskey <jlaskey at openjdk.org>
Date:   Thu Jun 11 10:08:23 2020 -0300

    8230744: Several classes throw OutOfMemoryError without message
    
    Reviewed-by: psandoz, martin, bchristi, rriggs, smarks

If that is fixed (perhaps in a different commit), then this commit is good.

History has shown that capacity growth code is highly errorprone, so it's worth writing whitebox tests, as I did in e.g. 

./java/util/concurrent/ConcurrentHashMap/WhiteBox.java
./java/util/ArrayDeque/WhiteBox.java
./java/util/HashMap/WhiteBoxResizeTest.java

-------------

Marked as reviewed by martin (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5878