RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]
Sean Coffey
coffeys at openjdk.java.net
Tue Oct 12 14:39:52 UTC 2021
On Tue, 12 Oct 2021 13:28:21 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>>
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
>
> 8193682 : Infinite loop in ZipOutputStream.close()
test/jdk/java/util/zip/GZIP/GZipLoopTest.java line 55:
> 53: private static Random rand = new Random();
> 54:
> 55: @Test
I think we can condense the test code to aid maintenance - please consider using DataProvider
-------------
PR: https://git.openjdk.java.net/jdk/pull/5522
More information about the core-libs-dev
mailing list