RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]

Alan Bateman alanb at openjdk.java.net
Tue Oct 12 14:49:53 UTC 2021


On Tue, 12 Oct 2021 14:11:15 GMT, jmehrens <duke at openjdk.java.net> wrote:

>> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8193682 : Infinite loop in ZipOutputStream.close()
>
> src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java line 256:
> 
>> 254:             } catch (Exception e) {
>> 255:                 def.end();
>> 256:                 out.close();
> 
> out.close not needed with try with resources.

This changes deflate to close the compressor and the output stream when there is an I/O exception. I expect this will need a spec change or a re-examination of the issue to see if there are alternatives.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5522


More information about the core-libs-dev mailing list