RFR: 8269336: Malformed jdk.serialFilter incorrectly handled

Roger Riggs rriggs at openjdk.java.net
Tue Oct 19 13:51:56 UTC 2021


On Mon, 18 Oct 2021 13:44:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review for this change which addresses https://bugs.openjdk.java.net/browse/JDK-8269336?
> 
> As noted in that issue, this change will now propagate any exception that occurred during parsing and creation of the filter configured through the `jdk.serialFilter` system property. It will also continue to log those errors, like it previously did.
> 
> A new jtreg test has been introduced to reproduce this issue and verify the fix. 
> 
> Given that invalid values for this system property will now start throwing exception, will this change need a CSR?

src/java.base/share/classes/java/io/ObjectInputFilter.java line 641:

> 639:                             "Error configuring filter: {0}", (Object) re);
> 640:                     // Do not continue if configuration not initialized
> 641:                     throw new ExceptionInInitializerError(re);

Just re-throw the RuntimeException.  
It will be caught by the caller of the static initialize and wrapped in ExceptioninInitializerError.

I don't think a CSR is needed since this exception is not part of an API.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5988


More information about the core-libs-dev mailing list