RFR: 8271515: Integration of JEP 417: Vector API (Third Incubator) [v3]

[Sandhya Viswanathan]

On Tue, 19 Oct 2021 18:54:01 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_vecApi.hpp line 29:
>> 
>>> 27: // the intent of this file to provide a header that can be included in .s files.
>>> 28: 
>>> 29: #ifndef SHARE_VM_UTILITIES_GLOBALDEFINITIONS_VECAPI_HPP
>> 
>> The file src/hotspot/share/utilities/globalDefinitions_vecApi.hpp is not needed.
>
> I notice src/jdk.incubator.vector/windows/native/libsvml/globals_vectorApiSupport_windows.S.inc contains a refence in comments to that file, I presume i can remove that comment too?

Yes, that comment can also be removed. It is a leftover from when svml was built as part of libjvm.so.

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java line 278:
>> 
>>> 276:     @Override
>>> 277:     @ForceInline
>>> 278:     public Byte128Vector lanewise(Unary op, VectorMask<Byte> m) {
>> 
>> Should this method be final as well?
>
> It's actually redundant because the class is final. Better to drop final from all declarations, at the risk of creating a larger diff.

Got it. I am ok with leaving things as is if it makes it easier.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5873