RFR: 8270490: Charset.forName() taking fallback default value [v3]

Sergey Bylokhov serb at openjdk.java.net
Sat Oct 23 01:46:07 UTC 2021


On Fri, 22 Oct 2021 17:33:43 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> During the review of JEP 400, a proposal to provide an overloaded method to `Charset.forName()` was suggested [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This PR is to implement the proposal. A CSR is also drafted as https://bugs.openjdk.java.net/browse/JDK-8275348
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed `@throws IllegalCharsetNameException`

src/java.base/share/classes/java/io/Console.java line 589:

> 587:         }
> 588:         if (cs == null) {
> 589:             cs = Charset.forName(StaticProperty.nativeEncoding(), Charset.defaultCharset());

Not sure but looks like this class tries to maintain 80 chars per line rule?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6045


More information about the core-libs-dev mailing list