RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v7]

Aleksei Efimov aefimov at openjdk.java.net
Tue Oct 26 12:55:11 UTC 2021


On Tue, 26 Oct 2021 12:49:30 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/spi/InetAddressResolverProvider.java line 45:
>> 
>>> 43:  * system-wide resolver instance, which is used by
>>> 44:  * <a href="{@docRoot}/java.base/java/net/InetAddress.html#host-name-resolution">
>>> 45:  * InetAddress</a>.
>> 
>> I think we should prune some some of the text from the class description to avoid repetition.  Here's a suggestion:
>> 
>> 1. Add the following immediately after the sentence "A given innovation ..."
>> "It is set after the VM is fully initialized and when an invocation of a method in InetAddress class triggers the first lookup operation. 
>> 
>> 2. Replace the text in L47-65 with:
>> "A resolver provider is located and loaded by InetAddress to create the systwm-wide resolver as follows:
>> 
>> 3. Replace the remaining three usages of "install" with "set".
>
> Thanks, changed as suggested: 1378686becfcbf18793556de8381b5ebcd79698d

Pruned `InetAddressResolverProvider` class-level doc as suggested: 1378686becfcbf18793556de8381b5ebcd79698d

-------------

PR: https://git.openjdk.java.net/jdk/pull/5822


More information about the core-libs-dev mailing list