RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v8]
Aleksei Efimov
aefimov at openjdk.java.net
Tue Oct 26 16:24:55 UTC 2021
On Tue, 26 Oct 2021 15:04:54 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Aleksei Efimov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>>
>> - Changes to address review comments
>> - Update tests to address SM deprecation
>> - Merge branch 'master' into JDK-8244202_JEP418_impl
>> - More javadoc updates to API classes
>> - Review updates + move resolver docs to the provider class (CSR update to follow)
>> - Change InetAddressResolver method names
>> - Remove no longer used import from IPSupport
>> - Rename IPSupport.hasAddress and update it to use SocketChannel.open
>> - Address review comments: javadoc + code cleanup
>> - Address resolver bootstraping issue
>> - ... and 4 more: https://git.openjdk.java.net/jdk/compare/1bbecc93...1378686b
>
> src/java.base/share/classes/java/net/InetAddress.java line 1151:
>
>> 1149:
>> 1150: Objects.requireNonNull(host);
>> 1151: Objects.requireNonNull(lookupPolicy);
>
> for consistency we could add `@throws NullPointerException` to the API doc of that method - since it seems to have everything else...
Added `@throws NullPointerException` to the hosts file resolver API docs: 2ca78ba98dc81cd6cc44b53dc7d56a6ae42c2736
-------------
PR: https://git.openjdk.java.net/jdk/pull/5822
More information about the core-libs-dev
mailing list