RFR: 8193682: Infinite loop in ZipOutputStream.close() [v5]

[Lance Andersen]

On Thu, 28 Oct 2021 11:56:45 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close operations on GZip we are not setting the deflator to a finished state which is leading to an infinite loop when we try writing on the same GZip instance( since we use while(!def.finished()) inside the write operation).
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8193682 : Infinite loop in ZipOutputStream.close()

I think we are closer.  

The formatting is better.  Thank you for changing the name for the constant.

Please add comments describing the intent of the test,  DataProvider, and BeforeTest method to make it clear to future maintainers when they look back on the tests.

We should still create a CSR to highlight the change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5522