RFR: 8272600: (test) Use native "sleep" in Basic.java [v3]

David Holmes dholmes at openjdk.java.net
Thu Sep 2 05:00:42 UTC 2021


On Wed, 1 Sep 2021 15:02:44 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> test/jdk/java/lang/ProcessBuilder/Basic.java line 2665:
>> 
>>> 2663: 
>>> 2664:             Path exePath = Path.of(TEST_NATIVEPATH).resolve("BasicSleep.exe");
>>> 2665:             System.out.println("exePath: " + exePath + ", canExec: " + exePath.toFile().canExecute());
>> 
>> What is this for??
>
> Ioi was concerned that the fallback to Java would be used silently and the old intermittent issue would return.

Well Ioi asked for a comment explaining why the fallback was necessary, but the println doesn't explain anything. I assume it should say something like "Unable to find ... falling back to Java version"?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5239


More information about the core-libs-dev mailing list