RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v2]

Naoto Sato naoto at openjdk.java.net
Tue Sep 7 19:07:03 UTC 2021


On Tue, 7 Sep 2021 18:46:56 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added a constant for nanos per micro.
>
> src/java.base/share/classes/java/time/Instant.java line 1170:
> 
>> 1168:         long secsDiff = Math.subtractExact(end.seconds, seconds);
>> 1169:         long totalMicros = Math.multiplyExact(secsDiff, NANOS_PER_SECOND / 1000);
>> 1170:         return Math.addExact(totalMicros, (end.nanos - nanos) / 1000);
> 
> Can you define NANOS_PER_MICRO, the others conversions use predefined constants.

Defined it as a private field in `Instant`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5396


More information about the core-libs-dev mailing list