RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v4]

Joe Wang joehw at openjdk.java.net
Wed Sep 8 00:19:09 UTC 2021


On Tue, 7 Sep 2021 20:29:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Please review the fix to the issue. Avoiding overflow by not calling nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved the constant to LocalTime for consistency.

Marked as reviewed by joehw (Reviewer).

test/jdk/java/time/test/java/time/TestInstant.java line 102:

> 100: 
> 101:     @Test
> 102:     public void test_microsUntil() {

A comment about the test might be helpful.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5396


More information about the core-libs-dev mailing list