RFR: 8273401: Remove JarIndex support in URLClassPath [v2]
wxiang
github.com+53162078+shiyuexw at openjdk.java.net
Wed Sep 8 06:22:45 UTC 2021
On Tue, 7 Sep 2021 10:50:39 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> wxiang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Some minor changes
>>
>> Include:
>> 1. remove public for INDEX_NAME in JarFile
>> 2. recover the definition for INDEX_NAME in JarIndex
>> 3. mv the test case JarIndexMergeTest.java into test/jdk/java/util/jar
>
> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 73:
>
>> 71: import static java.util.jar.JarFile.MANIFEST_NAME;
>> 72: import static java.util.stream.Collectors.joining;
>> 73: import static java.util.jar.JarFile.INDEX_NAME;
>
> Maybe move this above the java.util.streamCollectors.joining import
>
> Also, the copyright should probably be updated to 2021
update to 2021
> test/jdk/sun/misc/JarIndex/JarIndexMergeTest.java line 25:
>
>> 23:
>> 24: /*
>> 25: * @test
>
> Probably should update the copyright year to include 2021
The copyright year includes 2021.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5383
More information about the core-libs-dev
mailing list