RFR: 8273315: Parallelize and increase timeouts for java/foreign/TestMatrix.java test [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Wed Sep 8 11:37:12 UTC 2021
On Wed, 8 Sep 2021 09:17:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> This test runs a lot of configurations, and spends a lot of time serially. This is especially pronounced when run in prospective tier4 runs (JDK-8273314). There are reports of multi-hour runs (see JDK-8271613). We can parallelize the test configurations for this test to make it hurt less. Also, timeouts need to be increased for `TestUpcall` test configs, because some of them are very slow in fastdebug mode.
>>
>> Sample run:
>>
>>
>> $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=java/foreign/TestMatrix.java | ts -s
>> 00:00:00 Building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> 00:00:03 Test selection 'java/foreign/TestMatrix.java', will run:
>> 00:00:03 * jtreg:test/jdk/java/foreign/TestMatrix.java
>> 00:00:03
>> 00:00:03 Running test 'jtreg:test/jdk/java/foreign/TestMatrix.java'
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TTFT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FFFF
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FFTF
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TTTT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FTTT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FFTT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FFFT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TTTF
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FTTF
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TFFT
>> 00:00:31 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TFTF
>> 00:00:32 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TFFF
>> 00:00:32 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FTFF
>> 00:00:35 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TFTT
>> 00:00:35 Passed: java/foreign/TestMatrix.java#UpcallHighArity-TTFF
>> 00:00:38 Passed: java/foreign/TestMatrix.java#UpcallHighArity-FTFT
>> 00:01:50 Passed: java/foreign/TestMatrix.java#Downcall-FF
>> 00:02:27 Passed: java/foreign/TestMatrix.java#Downcall-TF
>> 00:03:03 Passed: java/foreign/TestMatrix.java#Downcall-FT
>> 00:03:47 Passed: java/foreign/TestMatrix.java#Downcall-TT
>> 00:04:17 Passed: java/foreign/TestMatrix.java#Upcall-FTFF
>> 00:04:23 Passed: java/foreign/TestMatrix.java#Upcall-TFFF
>> 00:05:46 Passed: java/foreign/TestMatrix.java#Upcall-TTFF
>> 00:06:03 Passed: java/foreign/TestMatrix.java#Upcall-TFFT
>> 00:06:44 Passed: java/foreign/TestMatrix.java#Upcall-FTFT
>> 00:08:24 Passed: java/foreign/TestMatrix.java#Upcall-TFTF
>> 00:08:39 Passed: java/foreign/TestMatrix.java#Upcall-TTFT
>> 00:09:16 Passed: java/foreign/TestMatrix.java#Upcall-FTTF
>> 00:09:19 Passed: java/foreign/TestMatrix.java#Upcall-TFTT
>> 00:10:01 Passed: java/foreign/TestMatrix.java#Upcall-FTTT
>> 00:10:37 Passed: java/foreign/TestMatrix.java#Upcall-TTTF
>> 00:12:16 Passed: java/foreign/TestMatrix.java#Upcall-TTTT
>> 00:12:17 Test results: passed: 32
>> 00:12:21
>> 00:12:21 ==============================
>> 00:12:21 Test summary
>> 00:12:21 ==============================
>> 00:12:21 TEST TOTAL PASS FAIL ERROR
>> 00:12:21 jtreg:test/jdk/java/foreign/TestMatrix.java 32 32 0 0
>> 00:12:21 ==============================
>>
>> real 12m20.538s
>> user 131m54.043s
>> sys 0m59.944s
>>
>>
>> If we don't parallelize, then those 130 minutes are spent serially.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Go "manual"
Changes looks good. Whether we want to use `manual` or `@stress` I'm not sure. I guess it depends a lot on which parameters are typically used by CI to run those tests.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5358
More information about the core-libs-dev
mailing list