RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v5]
Stephen Colebourne
scolebourne at openjdk.java.net
Wed Sep 8 15:38:11 UTC 2021
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>
> Added comments for the test.
`toEpochMilli()` overflows at large/small values. Thus any attempt to calculate the difference between two very large instants would fail.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5396
More information about the core-libs-dev
mailing list