RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]
Severin Gehwolf
sgehwolf at openjdk.java.net
Tue Sep 14 16:36:09 UTC 2021
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter pids.current , see https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html#pid
>> that would be helpful too and can be added to the OSContainer API .
>> pids.current :
>> A read-only single value file which exists on all cgroups.
>> The number of processes currently in the cgroup and its descendants.
>>
>> Best regards, Matthias
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify coding following Severins advice
Looks fine. I suggest to move the debug printing from line 99 to after line 101 as suggested here:
https://github.com/openjdk/jdk/pull/5437#discussion_r706145165
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5437
More information about the core-libs-dev
mailing list