RFR: 8273401: Disable JarIndex support in URLClassPath [v2]

wxiang github.com+53162078+shiyuexw at openjdk.java.net
Thu Sep 16 13:32:10 UTC 2021


On Thu, 16 Sep 2021 11:08:17 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> wxiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add isEmpty check
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 949:
> 
>> 947:                 return checkResource(name, check, entry);
>> 948: 
>> 949:             if (index == null || !ENABLE_JAR_INDEX)
> 
> Is this needed? When ENABLE_JAR_INDEX is false then I assume index will always be null. I'm only asking is that it would be nice if ENABLE_JAR_INDEX was checked in one place rather than two.

Yes, the check is redundant, and I removed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5524


More information about the core-libs-dev mailing list