RFR: 8273774: CDSPluginTest should only expect classes_nocoops.jsa exists on supported 64-bit platforms [v3]

Calvin Cheung ccheung at openjdk.java.net
Thu Sep 16 18:23:53 UTC 2021


On Thu, 16 Sep 2021 17:53:25 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> > The fix in the test case seems fine to me.
> 
> This test may fail in other cases. We should prepare for those cases in this fix:
> 
> ```
> if (!Platform.isDefaultCDSArchiveSupported() && !Platform.isAArch64()))
>     throw new SkippedException("not a supported platform");
> ```
I just noticed there was a bug fix [JDK-8269840](https://bugs.openjdk.java.net/browse/JDK-8269840) (Update Platform.isDefaultCDSArchiveSupported() to return true for aarch64 platforms). So the second condition in the above is not necessary.
> 
> Calvin suggests to throw SkippedException in an offline chat.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5519


More information about the core-libs-dev mailing list