RFR: 8272600: (test) Use native "sleep" in Basic.java [v6]

Roger Riggs rriggs at openjdk.java.net
Mon Sep 20 13:01:29 UTC 2021


> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified unexpected messages from a child Java VM
> as the cause of the test failure.  Attempts to control the output of the child VM have failed, the VM is unrepentant .
> 
> There is no functionality in the child except to wait long enough for the test to finish and the child is destroyed.
> The fix is to switch from using a Java child to using a native child; a new executable `sleepmillis`.

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  The switch from a Java child to /bin/sleep caused another test
  to fail on Linux.  The cleanup for a test used /usr/bin/pkill "sleep 60".
  A race between that cleanup and subsequent tests that used sleep 60 or 600
  could kill the sleep before the test of waitFor completed.
  Changing the test using pkill to use 59 seconds makes the test cleanup
  selective to the sleep spawned for that test.
  The test that was failing (lines 2626-2624) passes consistently.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5239/files
  - new: https://git.openjdk.java.net/jdk/pull/5239/files/43a54802..afa932d6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5239&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5239&range=04-05

  Stats: 25 lines in 1 file changed: 7 ins; 10 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5239.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5239/head:pull/5239

PR: https://git.openjdk.java.net/jdk/pull/5239


More information about the core-libs-dev mailing list