RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() [v2]

Naoto Sato naoto at openjdk.java.net
Tue Sep 21 22:18:08 UTC 2021


On Tue, 21 Sep 2021 22:03:30 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed the unnecessary space
>
> src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:
> 
>> 279:             month = 13 - (xm % 12);
>> 280:             if (month == 13) {
>> 281:                 year ++;
> 
> Not that it matters, just happen to see it ;-). Is it more common to have no space before the increment operator? Code convention seems to suggest no space before increment and their operands. 
> No update needed should you decide to remove it.

Thanks. Indeed it was in the coding convention. Removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5611


More information about the core-libs-dev mailing list