RFR: 8274276: Cache normalizedBase URL in URLClassPath.FileLoader [v2]

Сергей Цыпанов github.com+10835776+stsypanov at openjdk.java.net
Fri Sep 24 11:50:23 UTC 2021


On Fri, 24 Sep 2021 11:14:00 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8274276: Make URLClassPath.Loader.getBaseURL() final
>
> This is calling an overidable method within a constructor, which might have unforeseen side effects. Can you  make `Loader::getBaseURL` final? That would remove the concern.

@dfuch Sure, done!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5677


More information about the core-libs-dev mailing list