RFR: 8282221: x86 intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long [v6]
Vamsi Parasa
duke at openjdk.java.net
Tue Apr 5 20:26:20 UTC 2022
On Tue, 5 Apr 2022 17:06:44 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add bmi1 support check and jtreg tests
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp line 362:
>
>> 360: void vector_popcount_long(XMMRegister dst, XMMRegister src, XMMRegister xtmp1,
>> 361: XMMRegister xtmp2, XMMRegister xtmp3, Register rtmp,
>> 362: int vec_enc);
>
> This doesn't seem to be related to this patch.
This is coming due to a merge with the latest upstream (jdk)
> test/hotspot/jtreg/compiler/intrinsics/TestIntegerDivMod.java line 107:
>
>> 105: }
>> 106: if (mismatch) {
>> 107: throw new RuntimeException("Test failed");
>
> It would be good to print dividend, divisor, operation, actual result and expected result here.
Please see the updated error message in the recent commit.
> test/hotspot/jtreg/compiler/intrinsics/TestLongDivMod.java line 104:
>
>> 102: }
>> 103: if (mismatch) {
>> 104: throw new RuntimeException("Test failed");
>
> It would be good to print dividend, divisor, operation, actual result and expected result here.
Please see the updated error message in the recent commit.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7572
More information about the core-libs-dev
mailing list