RFR: 8284579: Improve VarHandle checks for interpreter [v2]

Paul Sandoz psandoz at openjdk.java.net
Mon Apr 11 16:31:42 UTC 2022


On Mon, 11 Apr 2022 10:03:58 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>>> How would the performance change if the `isDirect` and `checkExactAccessMode` merger was reverted?
>> 
>> Add around 15-20ns/op for these micros.
>
> Restructuring so that we only check `direct` once sounds reasonable at face value but would be a lot of churn for little gain (even in the interpreter testing a local boolean field is fast, and JITs will optimize this well).
> 
> The `LINK_TO_STATIC_ARGS_V` in the code generator seems like a remnant from an earlier iteration of this code. The `vform.getMemberName_V` method the code generator would emit a call to doesn't even exist. This should probably be cleaned up, separately. @PaulSandoz, WDYT?

I think it was some left-over from prototyping and was not cleaned up. AFAICT `getMemberName_V` never existed in an committed code. It's OK to remove the `LINK_TO_STATIC_ARGS_V` as part of this commit of you wish.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8160


More information about the core-libs-dev mailing list